This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Use golang 1.9.4 from website #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
changed the title
sbose78
approved these changes
Dec 18, 2018
|
The coverage build is taking too long because go1.9.4 doesn't support test cache. We'll have to merge #2378 so that we can use golang from epel. We'll use
|
Codecov Report
@@ Coverage Diff @@
## master #2383 +/- ##
=========================================
+ Coverage 69.9% 70.11% +0.2%
=========================================
Files 171 174 +3
Lines 16992 17121 +129
=========================================
+ Hits 11879 12005 +126
+ Misses 3953 3951 -2
- Partials 1160 1165 +5
Continue to review full report at Codecov.
|
corinnekrych
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openshiftio/openshift.io#4631 (comment)
We know the
/deployments/spacesAPI fails on prod-preview with go1.10.This PR builds fabric8-wit with go1.9.4. We will be upgrading the golang version in a separate PR but this PR will be used as a fallback when go1.10/go1.11 fail.